Use std::vector<char> instead of std::unique_ptr<char[]>
#828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
PatKamin
approved these changes
Oct 23, 2024
ldorau
force-pushed
the
Use_std_vector_char_instead_of_std_unique_ptr_char
branch
from
0aaee44 to
3db24c4
Compare
Contributor
Author
|
Rebased |
KFilipek
reviewed
Oct 23, 2024
test/provider_coarse.cpp
Outdated
| void *buf = buffer.get(); | ||
| // preallocate some memory and initialize the vector with zeros | ||
| std::vector<char> buffer(init_buffer_size, 0); | ||
| void *buf = buffer.data(); |
Contributor
There was a problem hiding this comment.
I assume implicit cast by Coverity due to type conversion:
data() returns value_type*, in this case char*
https://cplusplus.com/reference/vector/vector/data/
Use std::vector<char> instead of std::unique_ptr<char[]> because we do not need to use memset(0) in this case. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Use_std_vector_char_instead_of_std_unique_ptr_char
branch
from
3db24c4 to
a4080b4
Compare
lukaszstolarczuk
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
std::vector<char>instead ofstd::unique_ptr<char[]>because we do not need to use memset(0) in this case.
Checklist